rwesson / NEAT

Empirical analysis of ionised nebulae, with uncertainty propagation
GNU General Public License v3.0
9 stars 5 forks source link

Build faild #61

Closed Hellseher closed 1 year ago

Hellseher commented 1 year ago

Hi,

Me again :), I'm about to pack NEAT for Guix after ALFA was merged and all platform issue builds were resolved.

After first attempt to build the project I've got this error log:

starting phase `build'
gfortran -cpp -DPREFIX=\"/gnu/store/b737qyi86i8y4rbbjg5r763abwpmm4ly-neat-2.3\" -DVERSION=\"2.3\" -ffree-line-length-0 -Jsource/ -fopenmp -O3 -fno-backtrace source/globals.f90 -c -o source/globals.o
gfortran -cpp -DPREFIX=\"/gnu/store/b737qyi86i8y4rbbjg5r763abwpmm4ly-neat-2.3\" -DVERSION=\"2.3\" -ffree-line-length-0 -Jsource/ -fopenmp -O3 -fno-backtrace source/types.f90 -c -o source/types.o
gfortran -cpp -DPREFIX=\"/gnu/store/b737qyi86i8y4rbbjg5r763abwpmm4ly-neat-2.3\" -DVERSION=\"2.3\" -ffree-line-length-0 -Jsource/ -fopenmp -O3 -fno-backtrace source/oii_diagnostics.f90 -c -o source/oii_diagnostics.o
gfortran -cpp -DPREFIX=\"/gnu/store/b737qyi86i8y4rbbjg5r763abwpmm4ly-neat-2.3\" -DVERSION=\"2.3\" -ffree-line-length-0 -Jsource/ -fopenmp -O3 -fno-backtrace source/hydrogen.f90 -c -o source/hydrogen.o
gfortran -cpp -DPREFIX=\"/gnu/store/b737qyi86i8y4rbbjg5r763abwpmm4ly-neat-2.3\" -DVERSION=\"2.3\" -ffree-line-length-0 -Jsource/ -fopenmp -O3 -fno-backtrace source/extinction.f90 -c -o source/extinction.o
gfortran -cpp -DPREFIX=\"/gnu/store/b737qyi86i8y4rbbjg5r763abwpmm4ly-neat-2.3\" -DVERSION=\"2.3\" -ffree-line-length-0 -Jsource/ -fopenmp -O3 -fno-backtrace source/recombination_lines.f90 -c -o source/recombination_lines.o
gfortran -cpp -DPREFIX=\"/gnu/store/b737qyi86i8y4rbbjg5r763abwpmm4ly-neat-2.3\" -DVERSION=\"2.3\" -ffree-line-length-0 -Jsource/ -fopenmp -O3 -fno-backtrace source/helium.f90 -c -o source/helium.o
gfortran -cpp -DPREFIX=\"/gnu/store/b737qyi86i8y4rbbjg5r763abwpmm4ly-neat-2.3\" -DVERSION=\"2.3\" -ffree-line-length-0 -Jsource/ -fopenmp -O3 -fno-backtrace source/equib_routines.f90 -c -o source/equib_routines.o
gfortran -cpp -DPREFIX=\"/gnu/store/b737qyi86i8y4rbbjg5r763abwpmm4ly-neat-2.3\" -DVERSION=\"2.3\" -ffree-line-length-0 -Jsource/ -fopenmp -O3 -fno-backtrace source/quicksort.f90 -c -o source/quicksort.o
gfortran -cpp -DPREFIX=\"/gnu/store/b737qyi86i8y4rbbjg5r763abwpmm4ly-neat-2.3\" -DVERSION=\"2.3\" -ffree-line-length-0 -Jsource/ -fopenmp -O3 -fno-backtrace source/functions.f90 -c -o source/functions.o
gfortran -cpp -DPREFIX=\"/gnu/store/b737qyi86i8y4rbbjg5r763abwpmm4ly-neat-2.3\" -DVERSION=\"2.3\" -ffree-line-length-0 -Jsource/ -fopenmp -O3 -fno-backtrace source/filereading.f90 -c -o source/filereading.o
gfortran -cpp -DPREFIX=\"/gnu/store/b737qyi86i8y4rbbjg5r763abwpmm4ly-neat-2.3\" -DVERSION=\"2.3\" -ffree-line-length-0 -Jsource/ -fopenmp -O3 -fno-backtrace source/abundances.f90 -c -o source/abundances.o
gfortran -cpp -DPREFIX=\"/gnu/store/b737qyi86i8y4rbbjg5r763abwpmm4ly-neat-2.3\" -DVERSION=\"2.3\" -ffree-line-length-0 -Jsource/ -fopenmp -O3 -fno-backtrace source/commandline.f90 -c -o source/commandline.o
gfortran -cpp -DPREFIX=\"/gnu/store/b737qyi86i8y4rbbjg5r763abwpmm4ly-neat-2.3\" -DVERSION=\"2.3\" -ffree-line-length-0 -Jsource/ -fopenmp -O3 -fno-backtrace source/linefinder.f90 -c -o source/linefinder.o
gfortran -cpp -DPREFIX=\"/gnu/store/b737qyi86i8y4rbbjg5r763abwpmm4ly-neat-2.3\" -DVERSION=\"2.3\" -ffree-line-length-0 -Jsource/ -fopenmp -O3 -fno-backtrace source/weights.f90 -c -o source/weights.o
gfortran -cpp -DPREFIX=\"/gnu/store/b737qyi86i8y4rbbjg5r763abwpmm4ly-neat-2.3\" -DVERSION=\"2.3\" -ffree-line-length-0 -Jsource/ -fopenmp -O3 -fno-backtrace source/output.f90 -c -o source/output.o
source/output.f90:384:29:

  337 |     call ftpcld(unit,1,1,1,listlength,all_linelists(:,1)%wavelength,status)
      |                                      2
......
  384 |     call ftpcld(unit,9,i,1,1,uncertainty_array(2)+uncertainty_array(1),status)
      |                             1
Error: Rank mismatch between actual argument at (1) and actual argument at (2) (rank-1 and scalar)
source/output.f90:385:30:

  337 |     call ftpcld(unit,1,1,1,listlength,all_linelists(:,1)%wavelength,status)
      |                                      2
......
  385 |     call ftpcld(unit,10,i,1,1,uncertainty_array(2)-uncertainty_array(3),status)
      |                              1
Error: Rank mismatch between actual argument at (1) and actual argument at (2) (rank-1 and scalar)
source/output.f90:390:30:

  337 |     call ftpcld(unit,1,1,1,listlength,all_linelists(:,1)%wavelength,status)
      |                                      2
......
  390 |     call ftpcld(unit,12,i,1,1,uncertainty_array(2)+uncertainty_array(1),status)
      |                              1
Error: Rank mismatch between actual argument at (1) and actual argument at (2) (rank-1 and scalar)
source/output.f90:391:30:

  337 |     call ftpcld(unit,1,1,1,listlength,all_linelists(:,1)%wavelength,status)
      |                                      2
......
  391 |     call ftpcld(unit,13,i,1,1,uncertainty_array(2)-uncertainty_array(3),status)
      |                              1
Error: Rank mismatch between actual argument at (1) and actual argument at (2) (rank-1 and scalar)
source/output.f90:435:29:

  337 |     call ftpcld(unit,1,1,1,listlength,all_linelists(:,1)%wavelength,status)
      |                                      2
......
  435 |     call ftpcld(unit,3,j,1,1,uncertainty_array(2)+uncertainty_array(1),status)
      |                             1
Error: Rank mismatch between actual argument at (1) and actual argument at (2) (rank-1 and scalar)
source/output.f90:436:29:

  337 |     call ftpcld(unit,1,1,1,listlength,all_linelists(:,1)%wavelength,status)
      |                                      2
......
  436 |     call ftpcld(unit,4,j,1,1,uncertainty_array(2)-uncertainty_array(3),status)
      |                             1
Error: Rank mismatch between actual argument at (1) and actual argument at (2) (rank-1 and scalar)
make: *** [Makefile:85: source/output.o] Error 1

Default GCC / gfortran in Guix is 10 right now.

Thanks

rwesson commented 1 year ago

Thanks for packaging NEAT as well as ALFA! I believe I have fixed this issue with commit 3308ac79113b8a9c9d8d179c7a009206587e3989, which ensures that these calls to CFITSIO pass the correct types.

Hellseher commented 1 year ago

Hi,

Thanks for a rapid fix, I use release tag for packaging. I'll give it a go when you are ready with the release of new version with fixes.

Regards, Oleg

Hellseher commented 1 year ago

Hi,

The build has been passed Guix's commit 6113e0529d61df7425f64e30a6bf77f7cfdfe5a5 and NEAT v2.4.

Closing the issue as resolved.

Thanks, Oleg