search

rwf2 / Rocket

A web framework for Rust.
https://rocket.rs
Other
23.59k stars 1.52k forks source link

Missing license files in rocket_codegen-0.5.0.crate #2760

Closed wojnilowicz closed 1 month ago

wojnilowicz commented 2 months ago

What kind of documentation problem are you reporting?

Other

Where is the issue found?

https://crates.io/crates/rocket_codegen/0.5.0

What's wrong?

LICENSE-MIT and LICENSE-APACHE are missing in rocket_codegen-0.5.0.crate downloaded from https://crates.io/crates/rocket_codegen/0.5.0 Please add it to all your packages. I would like to package it as rpm for Fedora (which identifies missing license as a mistake and encourages upstream to include it) and it would make it easier. Thanks.

System Checks

SergioBenitez commented 2 months ago

Please feel free to submit a PR that adds the missing files. This is certainly unintentional. I suppose cargo is only including the files in the subdirectory, so this will affect the other crates in subdirectories as well.

wojnilowicz commented 1 month ago

@SergioBenitez could you accept following PRs:

  1. https://github.com/SergioBenitez/Devise/pull/6
  2. https://github.com/SergioBenitez/stable-pattern/pull/3
  3. https://github.com/SergioBenitez/Pear/pull/33

They solve the same issue as here but in your other crates. Thanks.