search

rwf2 / multer

An async parser for multipart/form-data content-type in Rust
MIT License
156 stars 35 forks source link

Fixes tests clippy ci #18

Closed Fishrock123 closed 3 years ago

Fishrock123 commented 3 years ago

@rousan Hi, I'm considering using multer-rs in a rebase of https://github.com/http-rs/http-types/pull/175 - i.e. multipart support for http-rs (Tide & Surf), hope these fixes are welcome!

(Along with this, I'm going to be looking at adding support here for futures::io::AsyncRead & friends as a build feature, and also possibly a build feature for using http-types instead of http.)

rousan commented 3 years ago

Hey, @Fishrock123 , thank you very much for your PR. I'm definitely looking forward to make this crate more clean and adding supports to be able to use it in any future executors (tokio or async-std).

So, here, the following constructs will have two different variants:

AsyncRead

and possibly for Http primitives:

And these could be configured using build features.

rousan commented 3 years ago

Also, as we develop any features and bug fixes in develop branch, could you please send the PR to develop branch instead of master.

Fishrock123 commented 3 years ago

Should I re-target this PR?

rousan commented 3 years ago

Should I re-target this PR?

Yes, to the develop branch.

Fishrock123 commented 3 years ago

It's honestly quite confusing that the primary branch is not the development branch, btw.

rousan commented 3 years ago

It's honestly quite confusing that the primary branch is not the development branch, btw.

It's just a development pattern. We use master branch for the latest stable code and develop for on-going unstable code.