search

rwf2 / multer

An async parser for multipart/form-data content-type in Rust
MIT License
156 stars 35 forks source link

Ignore extra data before the first boundary #20

Closed jebrosen closed 3 years ago

jebrosen commented 3 years ago

Fixes #16.

This needs some serious review and deserves more tests (with differently bad or incomplete boundaries), but it's roughly the approach I had in mind.

SergioBenitez commented 3 years ago

Did the GitHub action runner fail, or is there an infinite op somewhere?

jebrosen commented 3 years ago

I failed ot re-test one of the existing tests shortly before I pushed; it gets caught in an infinite loop.

SergioBenitez commented 3 years ago

@jebrosen If possible, could you add the tests that you propose?

jebrosen commented 3 years ago

Rebased (oh, or should I base this on develop?) and added a few more tests. I wanted to test a few error cases, but probably won't have much time available to tackle that until the weekend.

SergioBenitez commented 3 years ago

@rousan I propose we develop on the master branch. This is the general convention for open source, at least in the last ~5 years, and also offers greater visibility on the home page. If this is okay with you, I'll merge the develop branch on master.

rousan commented 3 years ago

Okay, master branch looks good. A few changes are pushed to develop branch before. So, please merge the develop branch to master to get the latest changes and then we will make a new major release and will delete the develop branch.

rousan commented 3 years ago

Also, let me know when you are planning to release a new version, I will just pull and release to crates.io.

SergioBenitez commented 3 years ago

@rousan Merged develop into master and killed develop.

Also, let me know when you are planning to release a new version, I will just pull and release to crates.io.

Sounds good. Happy to help with (point) releases as well, if you'd like.

rousan commented 3 years ago

As of now, I'm using the releez tool to automate the release process. As I don't want to be involved here, you also plan the release process and do/change whatever is required. Whenever you're planning to release, just inform me, I will just the run the release command and push to crates.io.