search

rwf2 / multer

An async parser for multipart/form-data content-type in Rust
MIT License
158 stars 37 forks source link

Update to tokio 1.0. #21

Closed SergioBenitez closed 3 years ago

SergioBenitez commented 3 years ago

Also updates hyper to 0.14 in dev-dependencies. Disables the 'routerify' example, presumably temporarily, as it is not compatible with tokio 1.0 or hyper 0.14.

rousan commented 3 years ago

@SergioBenitez, as we use develop branch for development purpose, can you please send the PR to develop branch?

rousan commented 3 years ago

Hey @SergioBenitez, I want you to be an active maintainer for this repo as I don't get enough time to maintain it properly. I invited you on Github to be a collaborator. Let me know your response.

SergioBenitez commented 3 years ago

Sounds good. Happy to help. Will let you know if this changes.

nitsky commented 3 years ago

@rousan Would you mind publishing a new release with the tokio v1 support? Thank you!

rousan commented 3 years ago

Okay, I will make a new major release today.

dbrgn commented 3 years ago

Thanks @rousan and @SergioBenitez for working on this!

rousan commented 3 years ago

@SergioBenitez, I couldn't get time to release the major version, do let me know if the master branch has the stable code, so that I can make a new release with latest version of Tokio and Hyper.

nitsky commented 3 years ago

@rousan I have been using the code on master successfully with tokio v1 and hyper v0.14

SergioBenitez commented 3 years ago

@rousan Yes, it's stable. I was hoping to review and merge at least #29 before the new release, but that should be semver compatible at should the rest of the PRs.

rousan commented 3 years ago

Okay, then we will release after merging that PR.

nitsky commented 3 years ago

Now that #29 has merged, are there any other blockers to releasing a version that supports tokio v1?