search

rwieruch / favesound-redux

🎶 A SoundCloud Client in React + Redux running in production. Live Demo and Source Code to explore React + Redux as a beginner.
http://www.robinwieruch.de/the-soundcloud-client-in-react-redux/
1.59k stars 249 forks source link

Bug: Volume Slider doesn't close #30

Closed rwieruch closed 7 years ago

rwieruch commented 7 years ago

The Volume Slider that is attached to the Player in the bottom doesn't close when the Player closes. However, that should be the case. It should be the same as the Playlist that is attached to the Player which disappears when the Player disappears.

screen shot 2017-05-26 at 10 29 22
rwieruch commented 7 years ago

Fixed in https://github.com/rwieruch/favesound-redux/pull/39 by @MiniPekka 🎉