search

rwieruch / favesound-redux

🎶 A SoundCloud Client in React + Redux running in production. Live Demo and Source Code to explore React + Redux as a beginner.
http://www.robinwieruch.de/the-soundcloud-client-in-react-redux/
1.59k stars 249 forks source link

Fixed issue #51 #53

Closed chriszhangusc closed 7 years ago

chriszhangusc commented 7 years ago

  1. Making the effect solid and giving it an offset would make the tooltip always display on top of the share button instead of where the user clicked.

  2. As for the hiding after a certain seconds part, at first, I tried to do the hiding in onClick of <a data-tip="Song URL Copied!" data-for="copy" onClick={...}>', but the onClick is not firing.. : ( An alternative way would be setting eventOff="mousemove" and delayHide={3000} to trigger the hiding logic whenever the user move the mouse. So until someone come up with why the onClick is not being triggered, this solution should be fine.

rwieruch commented 7 years ago

Nice fix and furthermore great improvement! Thanks 👍