search

rwieruch / favesound-redux

🎶 A SoundCloud Client in React + Redux running in production. Live Demo and Source Code to explore React + Redux as a beginner.
http://www.robinwieruch.de/the-soundcloud-client-in-react-redux/
1.59k stars 249 forks source link

Fix issue #64: dashboard title text not being fully displayed #65

Closed chriszhangusc closed 7 years ago

chriszhangusc commented 7 years ago

I fixed the issue by wrapping the text of the anchor with a span and gave it a line-height of 14px. However, do you think we should split the artist and track title into two separate lines other than fitting them into a single line as in the current version the title is being not fully displayed? Or we could give it a tooltip or title for the user to know the hidden part of the title?

rwieruch commented 7 years ago

Both versions, showing a tooltip or using two lines for it, could work. I am curios if the latter version would still look lightweight. But I am open for both if you like to change it.