rwieruch / favesound-redux

🎶 A SoundCloud Client in React + Redux running in production. Live Demo and Source Code to explore React + Redux as a beginner.

http://www.robinwieruch.de/the-soundcloud-client-in-react-redux/

1.59k stars 249 forks source link

Adds repeat song feature to player #70

Closed gokulchandra closed 6 years ago

gokulchandra commented 7 years ago

Repeat song Feature on the Nav bar.

68

rwieruch commented 7 years ago

Thank you @gokulchandra 🎉 Any chance that someone else wants to give his/her first review on this PR? You would have to checkout the branch by gokulchandra:repeat-song-feature and verify that the new functionality works and nothing else breaks.

zachyam commented 7 years ago

@rwieruch I can review this PR. What is the process like apart from manually verifying the new functionality and ensuring nothing else breaks?

rwieruch commented 7 years ago

@zyam that's the process right now 😅 I would love to have tests for it at some point, but I guess that's another step.

gokulchandra commented 6 years ago

Any updates on this PR? It has been a while. 😅

chriszhangusc commented 6 years ago

If nobody is reviewing it, I'll do it.

chriszhangusc commented 6 years ago

@gokulchandra Sorry for the late review, everything works perfectly fine, well done!

rwieruch commented 6 years ago

Good job @gokulchandra @MiniPekka 💯 👍