rwieruch / favesound-redux

🎶 A SoundCloud Client in React + Redux running in production. Live Demo and Source Code to explore React + Redux as a beginner.

http://www.robinwieruch.de/the-soundcloud-client-in-react-redux/

1.59k stars 249 forks source link

Upgrade to react 16 #71

Closed chriszhangusc closed 7 years ago

chriszhangusc commented 7 years ago

69

rwieruch commented 7 years ago

Great @MiniPekka Did you check that the enzyme tests are still running? In the MobX Favesound repository it was a problem. https://github.com/rwieruch/favesound-mobx/issues/14#issuecomment-333385672

chriszhangusc commented 7 years ago

@rwieruch Thanks for the heads up, I will fix it right away.

chriszhangusc commented 7 years ago

@rwieruch It's OK now. I have upgraded test dependencies for them to play nice with react 16. The issue was mainly caused by enzyme and react 16. Also, I have removed chai-enzyme because it does not support enzyme 3.0 and react 16 yet. Here: https://github.com/producthunt/chai-enzyme/issues/199

rwieruch commented 7 years ago

Wow, that's awesome @MiniPekka I will update the other PR about your changes (https://github.com/rwieruch/favesound-mobx/issues/14). Maybe we can cross check afterwards both PRs and simply merge them. Thanks again for your work! 🎉

chriszhangusc commented 7 years ago

@rwieruch Please don't merge this branch yet, there is a problem caused by the package-lock file generated by npm5. Officially, NPM recommends committing it but it is causing all sorts of unnecessary trouble. I have created a new PR for this: #72