rwieruch / favesound-redux

🎶 A SoundCloud Client in React + Redux running in production. Live Demo and Source Code to explore React + Redux as a beginner.
http://www.robinwieruch.de/the-soundcloud-client-in-react-redux/
1.59k stars 249 forks source link

Display and filter by tags #92

Open ohadschn opened 6 years ago

ohadschn commented 6 years ago
ohadschn commented 6 years ago

@rwieruch apologies for the bombardment, I hope I was not too bold. It's just that I was only recently exposed to this site and I really like it (especially since it saved me the effort of building something similar from scratch) and thought I could provide my feedback.

Perhaps I will even tackle some of these myself when I'm done with some other projects I have :)

BTW, there is a similar project here in case you didn't know about it: http://mixyard.com/ (though it is not open source and not actively developed).

rwieruch commented 6 years ago

No problem at all! Thanks for opening these Issues. They are great opportunities for newcomers to React to learn something new in an existing project! I will try to advertise these issues on Twitter :) But feel free to solve them yourself too!

rwieruch commented 6 years ago

Regarding the issue: I like the idea! I guess the only difficult decision is where to put those extra filters in the UI?

ohadschn commented 6 years ago

Well one easy way would be to add it to the list of things filtered by the current search box.

It might even be better - say I want to listen to rock mixes, what do I care if it's in the title, tag, or even artist name? They are all very likely to be what I want...