search

rwieruch / favesound-redux

🎶 A SoundCloud Client in React + Redux running in production. Live Demo and Source Code to explore React + Redux as a beginner.
http://www.robinwieruch.de/the-soundcloud-client-in-react-redux/
1.59k stars 249 forks source link

Add favicon #93

Closed ohadschn closed 6 years ago

ohadschn commented 6 years ago

For a site named favesound I think a nice prominent favicon would be fitting :)

image

rwieruch commented 6 years ago

Good idea! Can you come up with one? :)

ohadschn commented 6 years ago

There are many options, for example: https://www.flaticon.com/search?word=soundcloud https://www.iconfinder.com/search/?q=soundcloud&price=free

Most of them require attribution though, is that an issue?

rwieruch commented 6 years ago

I don't think so, it should be okay just mentioning it in the GitHub repo?

ohadschn commented 6 years ago

In the FlatIcon case, doesn't seem so:

For web usage: By placing a link with the text "designed by {Author's Name} from Flaticon" in a visible spot, so the author's authorship is noticeable

I don't think you can do it in Creative Commons either:

on a webpage featuring your audio recording, provide a credit list of material you used that adheres to best practices above

I am not a lawyer, but if we don't want to put an attribution on the site itself I think it may be safest to use an icon that doesn't require one. Here are some examples: http://aiconica.net/search/Soundcloud.

Alameen007 commented 6 years ago

Hey @rwieruch, can you assign me to this?

rwieruch commented 6 years ago

Sure @Alameen007

rwieruch commented 6 years ago

Added in https://github.com/rwieruch/favesound-redux/pull/121 by @Alameen007