search

rwightman / efficientdet-pytorch

A PyTorch impl of EfficientDet faithful to the original Google impl w/ ported weights
Apache License 2.0
1.58k stars 293 forks source link

Function description/use does not correspond to the implementation #126

Closed Andrjusha closed 3 years ago

Andrjusha commented 3 years ago

Hi! Thank you for your implementation, it helps a lot!

The issue is the following. The description of the method effdet.config.model_config.bifpn_config says that the 'sum' weight method is implemented, however by default it's put to 'fastattn':

p.weight_method = weight_method or 'fastattn'.

Finally the code further presumes that there are three different options of weight method:

name_to_config = { 'bifpn_sum': bifpn_config(min_level=min_level, max_level=max_level, weight_method='sum'), 'bifpn_attn': bifpn_config(min_level=min_level, max_level=max_level, weight_method='attn'), 'bifpn_fa': bifpn_config(min_level=min_level, max_level=max_level, weight_method='fastattn'), }

However only one option is implemented. And it's not clear which one: 'sum' or 'fastattn'.