search

rwightman / udacity-driving-reader

Quick docker based reader for udacity rosbag self-driving dataset. Dumps to png/jpg + csv or Tensorflow examples.
Apache License 2.0
162 stars 64 forks source link

Update Dockerfile and run.sh #18

Closed aayushARM closed 5 years ago

aayushARM commented 5 years ago

Changes related to issue #17 .

rwightman commented 5 years ago

@aayushARM Thanks again for the PR. I incorporated some of the changes to fix the python/pip package versioning issues into a separate commit that also updates to ROS melodic and newer tensorflow. Did a quick test and all works well...

I decided that I didn't want to change the defaults for the paths. The reason being, I feel that encouraging the data files and output to exist within the same path structure as these scripts (by defaulting to pwd) and the dockerfile is not the correct approach. When building the docker images, the context sent to the docker daemon is the contents of the full current folder, that could be huge with the data files. The paths for input and output should not be tied to this repo, and they will vary for all users so I'm not sure there are sensible defaults...