[enhancement] remove default units

[rwijtvliet]

To simplify the code, raise errors where before assumptions were made, about the unit of a value. Require the user to be more specific.

branch remove_defaults.

Some desired behaviour:

• When creating a PfLine, it is no longer sufficient to only specify the dimension abbreviation (w, q, p or r). A unit must also be provided, because a default is not assumed. So:

  # As currently:
  PfLine({'w': pd.Series([1, 2], pd.date_range('2024', freq='AS', periods=2), dtype='pint[MW]')}) # OK
  PfLine({'w': pd.Series([1, 2], pd.date_range('2024', freq='AS', periods=2), dtype='pint[MWh]')}) # raises error (incorrect dimensionality)
  PfLine({'w': pd.Series([1, 2], pd.date_range('2024', freq='AS', periods=2), dtype='pint[blablu]')}) # raises error (unknown unit)
  # New:
  PfLine({'w': pd.Series([1, 2], pd.date_range('2024', freq='AS', periods=2))}) # raises error (missing unit)

• Adding a float to a Price-PfLine:

  • Currently: assume the float is a price in a certain default unit.
  • Future: raise error.

The documentation is already updated.

Best approach is probably to first update the tests.

Tackle this issue before doing https://github.com/rwijtvliet/portfolyo/issues/88

[Pizza2Pizza]

PfLine({'w': pd.Series([1, 2], pd.date_range('2024', freq='AS', periods=2), dtype='pint[MWh]')}) # raises error (incorrect dimensionality) by calling it i get IndexError: tuple index out of range. is it correct?

[rwijtvliet]

Yes, it's correct. w indicates a power and expects a unit with dimension [energy]/[time], such as MW. q indicates an energy and expects a unit such as MWh or J. See here