rwilcox / odyssey

Rails, React, and deployment patterns
0 stars 0 forks source link

Vagrant setup #4

Closed jcarvin closed 7 years ago

jcarvin commented 7 years ago

I Set up a Vagrant machine so that I can run Docker on Windows without Hyper-V.

Setup

Tips from inside the machine

rwilcox commented 7 years ago

Neat! Good setup instructions, please add that to the README. Maybe separate them out, "Running Docker" and "Running Docker in Vagrant" ??

rwilcox commented 7 years ago

That rebase went... weird. (I'm not sure how to fix - I have a pretty big distrust of all but the most simple rebasing)

can you branch off master, and git cherry-pick your (4) commits from the vagrant_setup branch into the new branch? Make the one change I wanted, do another PR, we'll close this one.

Else I'm worried we'd have my commits repeated, which will look weird in the history...

jcarvin commented 7 years ago

Oh man. Yeah I'll get it fixed up asap. Sorry about that.

jcarvin commented 7 years ago

Replaced this branch with vagrant 3bec715