search

rwinch / spring-ldap

Apache License 2.0
0 stars 0 forks source link

LDAP-290: LdapTemplate logs message at INFO level instead of DEBUG when authentication exception is captured #118

Closed rwinch closed 8 years ago

rwinch commented 10 years ago

Original Reporter: cleung Environment: Not Specified Version: 1.3.2 Migrated From: https://jira.spring.io//browse/LDAP-290 When there is an authentication exception in the method below, a full stack trace is logged at info level; this is polluting the logs whenever a user cannot authenticate. Since the exception is added to the callback object it seems logical that the caller should decide what to do with this exception. Even a DEBUG message seems useless here.

public boolean authenticate(Name base, String filter, String password, final AuthenticatedLdapEntryContextCallback callback, final AuthenticationErrorCallback errorCallback)

rwinch commented 10 years ago

rwinch said: Thanks for the report. This has been updated to be debug level. Removal of the log statement all together was not ideal since we want the framework to assist in debugging failures as well.