search

rwinlib / gcc-4.9.3

Building R for Windows with the new gcc 4.9.3 toolchain
28 stars 7 forks source link

git2r installation #6

Closed jimhester closed 8 years ago

jimhester commented 8 years ago

Using the setup detailed in #5 I am getting the following error from git2r

cp winhttp/winhttp32.def.in winhttp.def
c:/Rtools/mingw_32/bin/dlltool --as c:/Rtools/mingw_32/bin/as  -k  --dllname winhttp.dll --input-def winhttp.def --output-lib libwinhttp.dll.a
c:/Rtools/mingw_32/bin/gcc  -I"C:/PROGRA~1/R/R-devel/include" -DNDEBUG     -I"C:/local/include"  -I.  -Ilibgit2 -Ilibgit2/include -Ihttp-parser -Iwin32 -Iregex -Ilibssh2/include -DWIN32 -D_WIN32_WINNT=0x0501 -D__USE_MINGW_ANSI_STDIO=1 -DGIT_WINHTTP -D_FILE_OFFSET_BITS=64 -DGIT_SSH -DGIT_ARCH_32   -O3 -Wall  -std=gnu99 -mtune=core2 -c libgit2/annotated_commit.c -o libgit2/annotated_commit.o
In file included from libgit2/annotated_commit.c:14:0:
libgit2/include/git2/annotated_commit.h:34:2: error: unknown type name 'git_annotated_commit'
  git_annotated_commit **out,
  ^
libgit2/include/git2/annotated_commit.h:51:2: error: unknown type name 'git_annotated_commit'
  git_annotated_commit **out,
  ^
libgit2/include/git2/annotated_commit.h:76:2: error: unknown type name 'git_annotated_commit'
  git_annotated_commit **out,
  ^

Looks to me like possibly libgit2 include is not being picked up properly. Have you run into this issue before? Does git2r require a patch to work with this toolchain?

jimhester commented 8 years ago

@jeroenooms Have you run into this problem with git2r before? Am I missing something obvious here?

jeroen commented 8 years ago

It was working before with the new toolchain but perhaps they introduced a new problem. I'll have a quick look.

jimhester commented 8 years ago

I am able to successfully build various other packages without issue, Rcpp, BH, digest... so I think I have everything setup properly

jimhester commented 8 years ago

If I use a LOCAL_SOFT containing just the libz library and headers I can get git2r to compile fine. It is just when I combine all the libraries together that I have issues.

jeroen commented 8 years ago

I have promised to help with refactoring the git2r configure scripts a while ago because it has issues on other platforms as well. I'll let you know when that's done, so you can ignore this package for now.

jeroen commented 8 years ago

OK this should now be fixed in the dev version of git2r.

jeroen commented 8 years ago

The new version of git2r is on CRAN now. @jimhester can you confirm problems are fixed and close this issue?

jimhester commented 8 years ago

Yep it works fine, thanks again Jeroen.