rwinlib / gdal2

Modern GDAL/PROJ/GEOS stack with lots of extra drivers
12 stars 9 forks source link

PROJ.4 datum grids are missing #2

Closed edzer closed 7 years ago

edzer commented 7 years ago

To convert to and from national grids (datums), PROJ.4 needs to have the grid definitions. These are currently not part of this distribution. They are part of the rgdal package, so need to get in here too. The grids are found in this file:

http://download.osgeo.org/proj/proj-datumgrid-1.6.zip

and need to be unpacked in directory gdal2-2.1.1/share/proj/

In future builds of this package, before configuring PROJ.4 this file should be unpacked in the proj-x.y.z/nad directory (x.y.z now being 4.9.3), installing PROJ.4 would copy over the files to the right place.

jeroen commented 7 years ago

Can you send a PR?

edzer commented 7 years ago

Done!

jeroen commented 7 years ago

OK it's merged. I also moved the v2.1.1 tag to HEAD so that you can keep using the same download URL.

edzer commented 7 years ago

I checked and everything worked out for sf 0.2-7 on CRAN, and appveyor. Thanks, Jeroen!

jeroen commented 7 years ago

Good to know, thanks.

edzer commented 7 years ago

The files I added in https://github.com/rwinlib/gdal2/commit/43f7368d616be4699f744970445c6a8ce9750448 are again missing from share/proj. Shall I add them in a new PR?

jeroen commented 7 years ago

@edzer ah that explains it, i'm sorry. Are these files not included with proj? The build script just replaced the entire /share/proj dir with the latest one I guess.

jeroen commented 7 years ago

@edzer I have re-applied your commit to head. Can you try to trigger a rebuild of sf ?

edzer commented 7 years ago

Thanks, will do!

@rsbivand I'm not sure now whether we should copy over the old files (like conus) or those in http://download.osgeo.org/proj/proj-datumgrid-1.5.zip which all have the .lla extension (conus.lla).

edzer commented 7 years ago

@jeroen this worked out!

jeroen commented 7 years ago

So everything is good now? I still see some diff's in the check but those are expected?

edzer commented 7 years ago

Yes, these diffs are all expected.