Support of new spring-data-commons API (v2) (breaks downward compability)

rwitzel / CouchRepository

Spring Data repositories for CouchDB

Apache License 2.0

17 stars 8 forks source link

Support of new spring-data-commons API (v2) (breaks downward compability) #2

Closed mueller-jens closed 5 years ago

rwitzel commented 5 years ago

Hi, Jens! Thank you for your contribution!

Do you mind to update the version in pom.xml and build.gradle to 1.0.0-SNAPSHOT? The library upgrade is an API change apparently.

mueller-jens commented 5 years ago

Yes i will do so this evening

mueller-jens commented 5 years ago

Hi Rodrigo, i have done the changes.

coveralls commented 5 years ago

Coverage increased (+0.1%) to 79.237% when pulling a124f459bf99c937d4a57acfaba76dae5001bcc0 on mueller-jens:master into 0581002d4a28acacc7117bf10a068328c9e1cff6 on rwitzel:master.

mueller-jens commented 5 years ago

Hi Rodrigo, one build faild, because of the new API uses Optionals, so it is not compileable with java7

rwitzel commented 5 years ago

@mueller-jens Hi Jens, thank you for the upgrade to Java8. Sorry for the delay. Could you

[x] remove oraclejdk7 from travis.yml (so that the build is successful), and
[x] update the section Prerequisites in the README.md (Java 8 now)?

Then the PR is ready for the merge.

mueller-jens commented 5 years ago

@rwitzel Hi I have changed to openjdk8 because oraclejdk8 is not longer supported. First try was to move to java 9 or higer but it doesn't work with gradle, so I have also raised the gradle version. hopefully it is ok for you

rwitzel commented 5 years ago

Thank you, Jens! Highly appreciated!