Switches `module` to `QUnit.module`

rwjblue / broccoli-jshint

MIT License

6 stars 30 forks source link

Switches `module` to `QUnit.module` #22

Closed snostorm closed 9 years ago

snostorm commented 9 years ago

According to http://qunitjs.com/upgrade-guide-2.x/ module will be removed from the global scope.

This was also causing me issues where this use of module was somehow conflicting with https://github.com/ModuleLoader/es6-module-loader and/or https://github.com/systemjs/systemjs

rwjblue commented 9 years ago

Looks good, I left a comment with a few more suggestions to make the output more QUnit 2.x ready.

Thanks for tackling!

snostorm commented 9 years ago

Sure, I'll pick that up a little later. Thanks for suggesting the extra 2.x steps. (I was mostly just fixing the part breaking for me now, but I switched to the fork for now anyway.)

snostorm commented 9 years ago

Requested changes added

rwjblue commented 9 years ago

Awesome, sorry for the delay!