search

rwjblue / git-repo-info

MIT License
112 stars 28 forks source link

Show the lastTag and the noOfAdditionalCommits #37

Closed luxzeitlos closed 6 years ago

luxzeitlos commented 7 years ago

To implement something like git describe and git describe --tags we need not only the tag of the current commit but the tag of the nearest commit in the chain of ancestors with a tag. Additionally we need to know how many additional commits this ancestor is away. This is how it works.

This is the basis to solve this issue.

hjdivad commented 7 years ago

thanks for working on this @luxferresum; LMK if any of my comments are unclear

luxzeitlos commented 6 years ago

Thanks for the review @hjdivad! I hope I was able to address all your concerns.

hjdivad commented 6 years ago

@rwjblue tests are failing due to arrow fn.

@luxferresum could fix, or we could bump major and drop support for ancient node.

your preference? (you already know mine...)

rwjblue commented 6 years ago

Lets update .travis.yml to run 4, 6, 8, and 9 and package.json's engine to be >= 4 (in a separate commit)...

hjdivad commented 6 years ago

awesome, thanks so much for the feature @luxferresum!

Looking forward to seeing https://github.com/EmberSherpa/ember-cli-app-version/issues/49

Looks like a good feature to add 👍

hjdivad commented 6 years ago

released as v2.0.0