rwmarcoux / f1-3-c2p1-colmar-academy

0 stars 0 forks source link

Media queries #3

Open martoio opened 6 years ago

martoio commented 6 years ago

I like that you changed the media query to a more sensible breakpoint. Tested your site on a number of screen presets and it looks good on all of them, so good work!

One thing that I found to be interesting in your code was that you had your media queries sprinkled throughout your code. Personally, I find it better to have one big media query at the end of the CSS (or even in a different CSS file). Your way is not wrong, it's just different from what most people would do. I would say try to make it into one block and see if it makes more sense.

If you are interested in learning some more about media queries, breakpoints - the what, when, where and how - I would recommend going through the Google Responsive Design guidelines. They provide examples and explanations of how and when to use breakpoints.

rwmarcoux commented 6 years ago

I have done one big block in the past, but in the codecademy lessons they have the queries after each section and after getting used to that method it made it easier for me to see what I was doing. I also tested it on my iPhone and was having some issues with the viewpoint and updated my code accordingly. Thank you for the feedback!