search

rwmt / Multiplayer

Zetrith's Multiplayer mod for RimWorld
MIT License
482 stars 98 forks source link

Linux vs Windows mod mismatch #386

Open PasixTheValkyrie opened 1 year ago

PasixTheValkyrie commented 1 year ago

Hello.

I've been trying to get a modded game working with my friend, who is playing on a Windows device, whilst I am playing on a Steam Deck.

I've tried several hours of getting to connect to his game, eventually sharing the entirety of his mod folder, config, etc needed to get it working.

I've noticed that the file sizes of the files he sends me change after I apply them and even though the files are exactly the same, I have a strong hunch that the file sizes are different because of newline encoding being different in Windows than it is in Linux.

The same config file for example was 8.7kb for him, whilst it was 8.4kb for me. I believe the \r\n vs \n difference might cause the Multiplayer mod to throw off a 'modified' file warning causing a myriad of issues.

notfood commented 1 year ago

I play Linux with my windows friends all the time. The config files are unmodified unless you enter the config panel, your friend is probably tinkering with the config making them different. Anyhow, MP will still let you connect if your files differ, as long as the defs are the same you are good.

Unless you are reporting a bug, check with the Discord people for support to avoid cluttering issues here.

PasixTheValkyrie commented 1 year ago

No, I can confirm this is happening consistently and you can very simply test it by having your Windows friends send over their config files.

It will block the Linux player from connecting to the Windows user, but not the other way around. Whether this is specifically a Proton thing or just Linux I can't tell for sure, however.

notfood commented 1 year ago

The files are untouched unless you open the settings. Rimworld can't edit them at all. Your files differ because they were touched. I basically never host as Linux. It's always the windows side.

PasixTheValkyrie commented 1 year ago

I'm afraid you're completely overlooking the issue as I wrote it.

It's not to do with Rimworld, it's most likely the newline encoding being interpreted as a change between Linux (Proton?) and Windows.

The fact you mention you barely host as Linux kind of shows you're overlooking what i'm raising as an issue.

Op vr 21 apr. 2023 05:57 schreef Meru @.***>:

The files are untouched unless you open the settings. Rimworld can't edit them at all. Your files differ because they were touched. I basically never host as Linux. It's always the windows side.

— Reply to this email directly, view it on GitHub https://github.com/rwmt/Multiplayer/issues/386#issuecomment-1516939210, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKJCLFUBCBNEU4WSVYASYHDXCGPLBANCNFSM6AAAAAAXFFKVHA . You are receiving this because you authored the thread.Message ID: @.***>

notfood commented 1 year ago

Even if you get the diff warning, you should be able to connect, the fact that isn't connecting means your configs differ on more than new lines. Approach support, this is not the right channel.

Zetrith commented 1 year ago

Line endings being significant is a valid issue. As for not being able to join, can you send a screenshot of the mismatch screen?

PasixTheValkyrie commented 1 year ago

These are the best I can offer you right now, as i'm not able to play with my pal right now.

image image image image

Interesting to note is that all the files were exactly identical as I copied them directly from his files.

We were using Charlotte's Multiplayer-able modpack.

Zetrith commented 1 year ago

Regarding the mod files, is there a chance one side received a workshop update after you synchronized the files? Can you verify the game's file integrity in Steam?

PasixTheValkyrie commented 1 year ago

Can verify equal files. Did all the basics in the book, including verifying game integrity. Only reason I made the github issue is since i've found no other ways to fix it in several hours.

Op wo 26 apr. 2023 08:17 schreef Zetrith @.***>:

Regarding the mod files, is there a chance one side received a workshop update after you synchronized the files? Can you verify the game's file integrity in Steam?

— Reply to this email directly, view it on GitHub https://github.com/rwmt/Multiplayer/issues/386#issuecomment-1522534639, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKJCLFRHGLTONC76DMHO7KTXDBLOZANCNFSM6AAAAAAXFFKVHA . You are receiving this because you authored the thread.Message ID: @.***>

Zetrith commented 1 year ago

If it isn't too much trouble, can you do a binary diff on the files in the mismatch screen?