rwmt / Multiplayer

Zetrith's Multiplayer mod for RimWorld
MIT License
462 stars 93 forks source link

Incorrect Needs in 3.9.4 #403

Open Zimgineering opened 7 months ago

Zimgineering commented 7 months ago

After 3.9.4 a pawns needs are not entirely correct in multiplayer.

Converting to Singleplayer yields the correct needs: image Converting that back to Multiplayer yields the incorrect needs: image

Reverting Multiplayer to 3.9.3 (3ec9c4c) resolves the issue.

Modlist (alphabetized)

Zimgineering commented 6 months ago

Issue persists, is there any additional info needed?

notfood commented 6 months ago

First and foremost, you need to test it with vanilla multiplayer only otherwise your bug report is invalid here.

Zimgineering commented 5 months ago

With only the Multiplayer, Multiplayer Compat, and Hugslib mods loaded we have roughly the same output:

Pre-convert to singleplayer: image Post-convert to singelplayer: image

notfood commented 5 months ago

Can you try on a new save? I suspect your global time is off in that save, giving the needs negative time and making them disappear. It also manifests as psycasts having insane or no cooldowns. It's fixed by editing the save manually and searching for ticksGame and altering it until it's right.

Zimgineering commented 5 months ago

Fresh vanilla+MP save has the same issue:

Singleplayer: image Multiplayer: image

Used a fresh install (deleted configs too) as well to be certain there wasn't any lingering local mods or DLC corruption.

Zetrith commented 5 months ago

This is caused by changes in 3cf6b22 which were made to reduce desyncs. The difference should be purely visual and the list should become correct if you let the game tick for a while (can you confirm it?). We'll work on a proper fix

Zimgineering commented 5 months ago

Yup, confirmed that the needs are corrected after letting it tick for a bit (works in the modded save too)

Thanks for the clarity!