rwntr / pokemon-infinity

This is a port of BuffelSaft's Pokemon Inclement Emerald to RHH's pokeemerald-expansion, with the goal of creating a more full-featured rom base for the creation of future projects.
0 stars 0 forks source link

IE Custom Abilities & Vanilla Tweaks + Upstream pokeemerald-expansion merge #2

Closed rwntr closed 1 month ago

rwntr commented 1 month ago

Description

Re-implementation of all custom abilities and changes to vanilla abilities (Blaze & co., Toxic Boost & co., Liquid Voice, etc.) from Inclement Emerald 1.13, including bug fixes for Power Fists - which was never working in IE as intended.

CHANGES FROM IE 1.13:

KEEN EDGE

Replaced by Sharpness from Gen IX. Sharpness has a buffed 1.5x modifier instead of the 1.3x from Keen Edge. Keen Edge has been inserted as a placeholder, but I do not currently intend to use it for any mons. Instead, Mega Absol, Mega Gallade etc. will be given Sharpness as a needed buff.

WHITEOUT

In addition to its returning 1.5x damage boost for ice-type moves in hail from IE, Whiteout now grants a smaller 1.3x damage boost in snow, on par with the damage boost from Sand Force. I justify this with the relative rarity of ice type attacking moves compared to ground/steel/rock, and hope that this can help somewhat rebalance ice as an attacking type.

POWER FISTS

Power fists was never actually working in Inclement Emerald.

The if-else block deciding which of the two defender mon's defensive stats to use in damage calculations terminated on all applicable punching moves before checks were performed for the attacker's ability. This resulted in Power Fists having a 1.2x damage boost akin to Iron Fists, but punching moves were still doing damage calculations on opponent's Defense as opposed to SpD, which was the intent. Power Fists now works as intended, providing a 1.2x boost to punching moves (same as Iron Fists, and same as Inclement Emerald) but now properly deals punching move damage as special damage.

PRISM SCALES

Replaced by Ice Scales from Gen IX. Ice Scales has a buffed 0.5x modifier instead of the 0.7x from Prism Scales. Prism Scales has been inserted as a placeholder, but I am undecided as to whether if any Prism Scales mons deserve the increased damage reduction they would get from having Ice Scales. I also think it's silly to have two versions of the same ability with one being objectively far superior, unless it's some legendary signature like Orichalcum Pulse. So for now, nothing needs to be done, but when I'm re-adjusting Pokemon stat totals, learnsets and abilities, I will come to a decision as to whether I want to fully scrap this ability or not.

People who collaborated with me in this PR

@JWGerbenGB

Discord contact info

@rwntr.