search

rwnx / pynonymizer

A universal tool for translating sensitive production database dumps into anonymized copies.
https://pypi.org/project/pynonymizer/
MIT License
101 stars 38 forks source link

Should INPUTS be mandatory when RESTORE_DB is skipped? #158

Closed simonblake-mp closed 3 months ago

simonblake-mp commented 4 months ago

Describe the bug An existing v1.x pynonymizer config that has PYNONYMIZER_START_AT='ANONYMIZE_DB'works fine without setting PYNONYMIZER_INPUT. In v2 it looks like INPUT has become mandatory - running v2.x against the same set of env vars that worked with v1.x, I get :

Missing values for required arguments:
Missing INPUT
Missing STRATEGYFILE

To Reproduce as above

Expected behavior Feels like INPUT should only be mandatory if the RESTORE_DB step is going to be in play?

Additional context

rwnx commented 4 months ago

Thank you so much for taking the time to write this up. This change wasnt intentional, I'll take a look at this with the other issues. Watch the patch milestone for updates https://github.com/rwnx/pynonymizer/milestone/4

rwnx commented 3 months ago

I've run some tests my side and I think this is because of the changes in #159, rather than a change to behaviour. when using the env vars from 2.2.0 it seems to work.