search

rwnx / pynonymizer

A universal tool for translating sensitive production database dumps into anonymized copies.
https://pypi.org/project/pynonymizer/
MIT License
101 stars 38 forks source link

PYNONYMIZER_STRATEGY dropped without deprecation #159

Closed simonblake-mp closed 3 months ago

simonblake-mp commented 4 months ago

Describe the bug A working v1.x pynonymizer config that has env var PYNONYMIZER_STRATEGY set is failing with v2 :

Missing values for required arguments:
Missing INPUT
Missing STRATEGYFILE

There's no mention in the CHANGELOG of PYNONYMIZER_STRATEGY being deprecated vs PYNONYMIZER_STRATEGYFILE - I'm wondering if it's been unintentionally dropped, as at the moment it's a breaking change without a prior deprecation?

To Reproduce as above

Expected behavior either PYNONYMIZER_STRATEGY continues to work, or a deprecation message

Additional context

simonblake-mp commented 4 months ago

likewise, PYNONYMIZER_START_AT (and presumably PYNONYMIZER_STOP_AT) have also been dropped without doc changes or a deprecation warning?

rwnx commented 4 months ago

Hi, thanks for reporting this. It looks like this was accidentally changed because of the differences in argument names in the new CLI library I'm using. This is absolutely a bug and I will restore the previous behaviour. I've added this to v2.2.1, stay tuned for updates.

rwnx commented 4 months ago

PYNONYMIZER_START_AT has been accidentally renamed to PYNONYMIZER_START_AT_STEP. I'll make sure this behaviour is reverted.

simonblake-mp commented 4 months ago

I've changed my pipelines to use the new variable names, other folks have probably done the same - might be nice to deprecate the new names rather than just a revert?

rwnx commented 3 months ago

Good suggestion, thanks! Both variations will be supported in 2.2.1. Closing this, but let's keep talking if it's not fixed.