search

rwnx / pynonymizer

A universal tool for translating sensitive production database dumps into anonymized copies.
https://pypi.org/project/pynonymizer/
MIT License
105 stars 38 forks source link

Typo: "running fafter script" #47

Closed rwnx closed 3 years ago

rwnx commented 3 years ago

present in mssql, mysql and postgres providers, there's an additional "F" character being added in the log line for running before/after scripts.

Remove it please!

            self.logger.info(f"Running f{title} script #{i} \"{script[:50]}\"")
itsabhianant commented 3 years ago

Hi @jerometwell,

I got what your issue is and according to me the change you want to be made is on

  1. pynonymizer/pynonymizer/database/mssql/init.py / - line 173
  2. pynonymizer/pynonymizer/database/mysql/init.py / - line 64
  3. pynonymizer/pynonymizer/database/postgres/init.py / - line 62

As per my understanding you want this to be changed:

 self.logger.info(f"Running f{title} script #{i} \"{script[:50]}\"")

to this:

 self.logger.info(f"Running {title} script #{i} \"{script[:50]}\"")

If I got all your issues along with the solution correct please assign this issue to me. Or else please explain in brief what more changes you want me to make related to this issue. Also, it will be great if you assign me this issue after explaining what the issue is so that I can start working on it as soon as possible.

Best, Abhishek

rwnx commented 3 years ago

Yeah that's what I was thinking 😇. I'll assign you the issue. Check out the CONTRIBUTING.md guide for general advice!

PR when ready!