search

rwnx / pynonymizer

A universal tool for translating sensitive production database dumps into anonymized copies.
https://pypi.org/project/pynonymizer/
MIT License
103 stars 38 forks source link

Fixed --> Typo: running fafter script (#47) #49

Closed itsabhianant closed 3 years ago

itsabhianant commented 3 years ago

Fixes #47

itsabhianant commented 3 years ago

Hi,

I fixed the issue stated on #47. Please let me know if something else is to be done related to the same issue.

Best, Abhishek

rwnx commented 3 years ago

Hi @itsabhianant can you add a line to the CHANGELOG.md file describing your change (to humans)

it's one of the things mentioned in CONTRIBUTING.md.

Also, as an aside, my-new-feature isn't a very descriptive branch name. It's not a dealbreaker, but normally this information gets captured in merge commits and stuff so it helps to use that to describe what the branch was for originally.

Otherwise looks good!

itsabhianant commented 3 years ago

Where exactly I have to write about the recent changes in CHANGELOG.md?

rwnx commented 3 years ago

from CONTRIBUTING.md

Add an entry to the CHANGELOG.md file, under the [Unreleased] section. [...] Try to describe what you've achieved from a user-facing perspective