rwnx / pynonymizer

A universal tool for translating sensitive production database dumps into anonymized copies.
https://pypi.org/project/pynonymizer/
MIT License
102 stars 38 forks source link

fixed locale override and added corresponding tests #79

Closed derfryday closed 3 years ago

derfryday commented 3 years ago

The current code does not allow for setting the locale in the strategyfile by always overwriting it as described in this issue: https://github.com/jerometwell/pynonymizer/issues/78

rwnx commented 3 years ago

Hi, thanks for your contribution! (especially the tests!) Could you put a line in the [Unreleased] section in the changelog.md for this fix?

It makes packaging and releasing easier on this side :)

derfryday commented 3 years ago

Hi, thanks for your contribution! (especially the tests!) Could you put a line in the [Unreleased] section in the changelog.md for this fix?

It makes packaging and releasing easier on this side :)

done.

rwnx commented 3 years ago

Hi,

I think it might have been confusing because there's no gap there, but the changelog needs be edited under the Unreleased heading. I think you've added it to the 1.21.0 section instead? 😇

i.e.

## [Unreleased]
+++ - Fixed a bug in the config parser that would always override the locale with either the cli argument or the fallback
## [1.21.0] 2021-05-31
- Added Custom Providers to strategyfiles. You can now include custom Faker providers in your
  strategyfiles, using the `providers` top-level key.
- Added Locale key `locale`(top-level) to strategyfiles. This is designed to replace the `-l`/`--fake-locale` CLI option. 
- Deprecated `-l`/`--fake-locale` option. You should use the `locale` key in your strategyfile. 
  This will be removed in a future release.
- Fixed a bug in postgres where table and column names were not consistently escaped. 
- Fixed some documentation errors.
--- - Fixed a bug in the config parser that would always override the locale with either the cli argument or the fallback
derfryday commented 3 years ago

Hi,

I think it might have been confusing because there's no gap there, but the changelog needs be edited under the Unreleased heading. I think you've added it to the 1.21.0 section instead? 😇

i.e.

## [Unreleased]
+++ - Fixed a bug in the config parser that would always override the locale with either the cli argument or the fallback
## [1.21.0] 2021-05-31
- Added Custom Providers to strategyfiles. You can now include custom Faker providers in your
  strategyfiles, using the `providers` top-level key.
- Added Locale key `locale`(top-level) to strategyfiles. This is designed to replace the `-l`/`--fake-locale` CLI option. 
- Deprecated `-l`/`--fake-locale` option. You should use the `locale` key in your strategyfile. 
  This will be removed in a future release.
- Fixed a bug in postgres where table and column names were not consistently escaped. 
- Fixed some documentation errors.
--- - Fixed a bug in the config parser that would always override the locale with either the cli argument or the fallback

Oh my bad, you are absolutely right, I pushed the fix.