rwtema / Careerbees

Repo for Career Bees. A mildly silly bee mod.
10 stars 6 forks source link

Fix for the Assassin bee crashing servers and sided RF / Energy bee issues #39

Open mjevans opened 4 years ago

mjevans commented 4 years ago

Thank you for helping to make Bees fun and worth doing in packs that include your mod (especially when combined with Gendustry).

While fixing a server crashing bug with the Assassin bees, I also looked over the other currently open issues and made the Energy bee work with sided blocks (by checking the null/internal side, as well as all the others).

Please accept this contribution of code. As there isn't an existing license specified nor a contributor agreement to look at and since the additions are either purely derivative works or arguably the obvious way for someone skilled in the art to resolve the problem (and thus not fit for copyright alone): I grant non-revocable, transferable, non-exclusive (you have them, I have them for my contributions alone, etc) rights to the code that I have offered for addition in the combined work.

It should resolve the following bugs, and I have built and tested these locally in single player.

src/main/java/com/rwtema/careerbees/effects/EffectAssassin.java Fix bugs #22 #25 (do not work on source hive) Fix bugs #23 #37 (use canHandleBlock guard) (and my issue) https://github.com/DarkPacks/Crackpack-3/issues/113

src/main/java/com/rwtema/careerbees/effects/EffectPower.java Fix #17 (work on any valid side, including 'internal' / null) and refactored to de-duplicate code