search

rwtema / Careerbees

Repo for Career Bees. A mildly silly bee mod.
10 stars 6 forks source link

Clean patch fix for the Assassin bee crashing servers and sided RF / Energy bee issues #40

Open mjevans opened 4 years ago

mjevans commented 4 years ago

This is a cleaner pull request (than #39 ) with only a small change based on further review of the code that I had refactored; I realized that I had missed the possibility of another mod returning more consumed energy than sent energy since that seemed like an obvious bug. A trace level logger call has been added in case someone is debugging such an issue.

-

Thank you for helping to make Bees fun and worth doing in packs that include your mod (especially when combined with Gendustry).

While fixing a server crashing bug with the Assassin bees, I also looked over the other currently open issues and made the Energy bee work with sided blocks (by checking the null/internal side, as well as all the others).

Please accept this contribution of code. As there isn't an existing license specified nor a contributor agreement to look at and since the additions are either purely derivative works or arguably the obvious way for someone skilled in the art to resolve the problem (and thus not fit for copyright alone):

I grant non-revocable, transferable, non-exclusive (you have them, I have them for my contributions alone, etc) rights to the code that I have offered for addition in the combined work, please use or share it as you desire with whatever license you desire.

It resolves the following bugs, and I have built and tested these locally (both in the prior iteration, and the current code on a server-side only patch which works correctly without the client updated).

Fix bugs #22 #25 (do not work on source hive) Fix bugs #23 #37 (use canHandleBlock guard) (and my issue) https://github.com/DarkPacks/Crackpack-3/issues/113

src/main/java/com/rwtema/careerbees/effects/EffectPower.java Fix #17 (work on any valid side, including 'internal' / null) and refactored to de-duplicate code Also include the logger to annotate the 'sent too much' corner case covered by the code this replaces (in case other mods are glitchy about storing too much energy).

SirpwnsalotIII commented 2 years ago

Any idea if this has been put into the current patch for 1.12?