search

rwtema / DenseOres

53 stars 51 forks source link

Console error when SpongeForge is installed #122

Open NEXUS2345 opened 8 years ago

NEXUS2345 commented 8 years ago

In the current DenseOres alpha, if any dense ore is broken while SpongeForge is installed, the following console error is thrown: https://gist.github.com/NEXUS2345/405bc2e4bd054249044b

Following this, for other clients connected to the server, the block appears to not break, and for all clients in the area, it becomes impossible to break certain block types. This only occurs if SpongeForge is installed and does not depend on the DenseOres version.

The SpongeForge issue can be found here: https://github.com/SpongePowered/SpongeForge/issues/580

Aaron1011 commented 8 years ago

@rwtema: While Sponge is causing this issue, we can't completely resolve it without your help.

In BlockDenseOre#getExpDrop, you check if the IBlockAccess passed in is a World. I'm going to change Sponge to pass in a proxy IBlockAccess that will work correctly, but it won't be a World.

Is it possible for you to change your check to allow Sponge to pass in its own IBlockAccess implementation (e.g. changing your code to check for the specific type of IBlockAccess you don't want).

Nachty commented 8 years ago

Is someone looking into this issue?