rwtema / DenseOres

53 stars 51 forks source link

DenseOre class, getSmeltingRecipe method: smelt field not being initialized #28

Closed fooblinator closed 10 years ago

fooblinator commented 10 years ago

Not a bug that I am experiencing, but I have been reading through the code trying to learn how this mod works, and I noticed that in the getSmeltingRecipe method of DenseOre class, the smelt field is being returned if initSmelt is true, however, it looks like the smelt field is never initialized. When you run through the first pass through getSmeltingRecipe, initSmelt is set to true, and there is an ItemStack generated and returned, but smelt is never set.

I'm sure this isn't what was intended, but not sure if it will ever cause a bug (will getSmeltingRecipe ever be called more than once?)