rwtema / DenseOres

53 stars 51 forks source link

Use getDrops() instead of quantityDropped() and getItemDropped() #51

Closed p-schneider closed 9 years ago

p-schneider commented 9 years ago

This fixes 2 Issues I stumbled across:

The issue with Railcraft is not that bad since it is giving me the correct ore blocks. The issue with Forestry is worse because it gives the wrong ore type. (damageDropped(int) always returns 0)

This Screenshot shows what i get when breaking dense ores in version 1.4.2. denseores142

Fix Forestry?

Should I open an Issue/PR on @ForestryMC to ask if they could fix it on their side? (class forestry.core.gadgets.BlockResource)

@Override
public int damageDropped(int metadata) {
    return metadata;
}

This simple function does fix the problem with always getting apatite ore blocks, but for apatite it would still give 3 ore blocks instead of 10-20 apatite shards. (because getItemDropped(...) returns the ore block like it does in railcraft).

rwtema commented 9 years ago

I think we should switch entirely to getDrops() and not bother with the uantitydropped,etc.. I'll fix it myself. Don't worry about opening up an issue with forestry.