search

rwtema / DietHopper

Other
4 stars 2 forks source link

Removes Recipes from other mods using hoppers as an ingredient #5

Open vadis365 opened 6 years ago

vadis365 commented 6 years ago

Hello, I have a mod which creates an upside down hopper called an upper. It seems the 1.12 version of this mod causes an issue with uppers recipes. I have a recipe that allows a 1 for 1 conversion of hoppers to uppers and back. For some reason this mod prevents it from working. Tested with just Diet Hopper, Uppers and JEI. Seems it it happening in many forge versions for many people. Uppers mod is on curse, but I never set a repo up for it on git - it's just simple recipes, nothing funky. Mod Link here: https://minecraft.curseforge.com/projects/uppers#c22 Let me know if you need any more info, or need some visible SRC - and I'll slap it on a repo. Cheers, Me.

*Edit - Tested with another of my mods, Mob Grinding Utils: https://minecraft.curseforge.com/projects/mob-grinding-utils Issue happens in a recipe in that mod too.

tifkat commented 6 years ago

Testing 1.12.2 with EnderIO nightly build 5.0.262 and EnderIO refuses to load with diethopper-1.1 installed.

Error given is the recipe for "Filter, Basic" is invalid because it can't find an ingredient 'blockHopper'.

Could oredict entries be missing/messed up?

tyler489 commented 6 years ago

Breaks enderio recipies too

tifkat commented 6 years ago

@tyler489 I guess I could have cross-reported the issue, so you guys would have been aware of it. But I felt this was the right place to make the issue report.

HenryLoenwind commented 6 years ago

After further investigation it turns out that new ItemStack(Item.getItemFromBlock(Blocks.HOPPER)) gives an EMPTY itemStack after Diet Hoppers' preInit has run.

It works if executed before Diet Hoppers' preInit and the itemStack stays valid.

HenryLoenwind commented 6 years ago

ok, today I learned something new. Accessing any vanilla block/item/MobEffect/Biome/Enchantment/Sound/PotionType during preinit (or the Register<> events) is not valid.

HenryLoenwind commented 6 years ago

On second thought, I'd say DietHopper registering the substitution outside the Register<Block> event is a bug.

Arudarin commented 6 years ago

@rwtema @HenryLoenwind is fixing this possible?

tyler489 commented 6 years ago

Of course its possible.... it might even be probable ;) it depends if tema feels like fixing what they think isnt a bug.

Arudarin commented 6 years ago

Well, it seems Tema has kinda abandoned this mod, which is unfortunate. If I knew how to fix it, I would PR.