search

rwtema / Extra-Utilities-2-Source

Sourcecode for Extra Utilities
Other
108 stars 75 forks source link

[1.12.2] Bag of Holding shift-click issues #228

Open ghost opened 6 years ago

ghost commented 6 years ago

Shift-clicking items into a full bag of holding, or from a bag of holding to full inventory causes an infinite loop (javaw.exe hangs without crash report).

EDIT:

aerde commented 5 years ago

Can confirm, having the same issue.

moktok commented 5 years ago

Can concur with OP Included log

latest.log

ghost commented 5 years ago

Can concur with OP Included log

latest.log

I haven't been able to get a crash log, this seems like it might have to do with MouseTweak's shift-click-and-drag, which would make sense as my modpack includes MouseTweaks 2.9 @YaLTeR

YaLTeR commented 5 years ago

Looking at the log, the infinite (or at least long enough to cause a stack overflow) recursion is between these three calls:

at com.rwtema.extrautils2.gui.backend.DynamicContainer.func_184996_a(DynamicContainer.java:491) ~[DynamicContainer.class:?]
at net.minecraft.inventory.Container.func_75133_b(Container.java:525) ~[abd.class:?]
at net.minecraft.inventory.Container.func_184996_a(Container.java:267) ~[abd.class:?]

which happen when MouseTweaks calls handleMouseClick().

Agret-Brisignr commented 5 years ago

I can also confirm that this is an issue.

YaLTeR commented 5 years ago

@ThatOneCheetah to check if the crash indeed requires MT to happen, could you try disabling shift + left click + drag functionality in MT's options?

ghost commented 5 years ago

@ThatOneCheetah to check if the crash indeed requires MT to happen, could you try disabling shift + left click + drag functionality in MT's options?

Seems to happen with the tweaks disabled too. As well as with MouseTweaks disabled in the modpack, I should've tested that first in retrospect. @YaLTeR

So it's either an issue with Extra Utilities 2, or the Forge API itself (if there is such a common API for managing inventories).

TheSnowyChickens commented 5 years ago

Same crash. :=)

JBSTheGamer commented 5 years ago

I have the same issue. This was a reported issue about this a while back in the old EU2 issue reporting website. Im wondering why its still not fixed. I really want to use this bag again without having to worry about the game crashing and loosing all my items in the bag at the bad its self being voided. It voids the bag and i loose all my items in it after i come back on after the crash.

SReject commented 5 years ago

Same issue but I do not have the MouseTweaks mods installed.

Description

  1. EU2 causes the game to stop responding if a user attempts to use hotkeys to move items from their inventory into a Golden Bag of Holding if the items to be moved would over fill the bag
  2. EU2 causes the game to stop responding if a user attempts to use hotkeys to move items from a Golden Bag of Holding into their inventory if they do not have enough inventory space to hold all items to be moved.

Versions

Minecraft: 1.12.2 Forge: 14.23.5.2775 Extra Utilities 2: 1.9.8

Steps reproduce: Golden Bag of Holding can't hold all items

  1. Mostly fill bag of holding with dirt blocks
  2. Fill player inventory with enough stacks of dirt to overfill bag of holding
  3. Pick up dirt block from player inventory
  4. Double click another stack of dirt blocks in player inventory

Steps to reproduce: Player inventory can't hold all items

  1. Fill Golden Bag of Holding with stacks of dirt blocks
  2. Pick up a stack of dirt blocks from bag of holding
  3. Double click on another stack of dirt blocks in bag of holding

I don't have a crash report(as its not an error, but rather a frozen game), but here's my latest.log after restarting after crash.

vtilroe commented 5 years ago

Confirmed using Extra Utilities 1.9.8 [1.12.2] in the Enigmatica 2 [v1.5.3] mod-pack; (accidentally) shift-clicking item from inventory into a full Golden Bag of Holding consistently hangs the Minecraft engine, requiring a forced [ctrl-alt-del] restart and reload of the mod-pack. Very annoying!

BrainStone commented 5 years ago

Can confirm that this only happens with Mouse Tweaks

Happens with and without Mouse Tweaks. So definately seems to be an EU issue.

cwstra commented 5 years ago

Came here with this problem, looked through past issues. Based on #254, upgraded from 1.9.8 to 1.9.9, seems to have solved the issue, both when shift-clicking into the bag, and out of the bag. I hypothesize that many related open issues (#155, #220, #226, #227, #232, #243, #260, #288, #294) are solved with 1.9.9, but would probably double-check before closing.