rwtema / FunkyLocomotion

a frames mod
Other
28 stars 36 forks source link

Fix infinite NBT tag recursion in getUpdateTag(). Fixes #101. #104

Open maruohon opened 7 years ago

maruohon commented 7 years ago

I don't really know what the purpose of the TileMovingBase.desc tag is, and when it is supposed to be populated and why... so this fix might break stuff. But at least the current code causes an infinite NBT tag recursion when the getUpdateTag() calls writeToNBT() and gives it the desc tag to write to, and it then writes the desc tag inside itself.... This causes the clients to disconnect when they try to read that infinitely recursive tag and also causes StackOverflow fun on the server whenever something is moved on a dedicated server.

Moke3 commented 7 years ago

Hey man, do you know if i could download this in a .jar file as a sort of patched FunkyLocomotion? I've tried some different ways without success since i don't do this normally, but i really enjoy the mod and want it fixed. Having a hard time to get it into both my Server and my own FTB laucher

Cheers

maruohon commented 7 years ago

@Moke3 Do you use reddit or Discord? I can link you the build I have been using on my testing server (which also has some other small fixes), but I don't want to link that publicly as I assume I don't have the permission to really redistribute it. I'm on Discord as masa#5718, and I also have my own channel on the MMD server, or on reddit as /u/masa_ so you can message me on either of those and I'll give you the link to my build.

Or alternatively, if you want to build it yourself, clone or download the zip from here: https://github.com/maruohon/FunkyLocomotion/tree/masa ie. make sure you get the masa branch if you are on 1.10.2. Then, to build it:

deadspidervenom commented 7 years ago

@maruohon hey mind sending me the 1.10.2 fix for funky locomotion, my discord is deadspidervenom#8644