search

rwtema / extrautilities_old_issues

Issue tracker
70 stars 45 forks source link

Uppercase/Lowercase conversion causes crash in Turkish locale #1687

Open Rupurudu opened 7 years ago

Rupurudu commented 7 years ago

Minecraft crashes with error "class com.rwtema.extrautils2.blocks.BlockPassiveGenerator has property: generatortype with invalidly named value: wınd"

My guess is this error is caused by ".toLowerCase()" which, without any arguments uses current locale. In Turkish locale lowercase conversion of "I" is "ı" (dotless i), which you can see it happen on the error.

Please change those to "toLowerCase(Locale.ENGLISH)) or "toLowerCase(Locale.ROOT))"

This is tested on Minecraft 1.12 and Extra Utilities 1.6.1 but it looks like other Minecraft and Extra Utilities combinations are also affected by this bug.

More info about this: https://garygregory.wordpress.com/2015/11/03/java-lowercase-conversion-turkey/

Rupurudu commented 7 years ago

Issues #1376 and #1661 is also caused by same issue. @BM-Black @TunaBuilder

Rupurudu commented 7 years ago

crash-2017-09-11_16.27.33-server.txt

Kritzkieg commented 7 years ago

Ben javaya yeniyim nasıl tolowercase yapılır anlamadım tutorial izledim kendi yaptığım stringde ekleyebiliyorum fakat buna yapamıyorum sen lütfen bana atabilirmisin locale root olanı?