search

rwtema / extrautilities_old_issues

Issue tracker
70 stars 45 forks source link

[1.7.10] Transfer Node needlessly calls `markDirty` on extraction #883

Open codewarrior0 opened 8 years ago

codewarrior0 commented 8 years ago

Re: https://github.com/jaquadro/StorageDrawers/issues/294 extrautilities-1.2.12

Did some decompiling to figure this one out:

A Transfer Node with a Stack Upgrade and a Filter is attached to a large inventory (a Controller Slave from Storage Drawers). While the node is filling its internal buffer from the inventory, it will go through each inventory slot and check if it matches the filter. If the slot does not match the filter (no items are extracted), and the node has a Stack Upgrade, it will call markDirty on the inventory for each non-matching slot.

Blue64 commented 7 years ago

isn't that so it knows not to scan there again to avoid infinite loop searches?