search

rwth-acis / REST-OCD-Services

This repository contains the OCD service of WebOCD. In the repository, java based codes of overlapping community detection algorithms (OCDA) can be found.
Apache License 2.0
14 stars 10 forks source link

Fix mix-up of cover ID and graph ID preventing cover deletion #10

Closed MaxKissgen closed 4 years ago

MaxKissgen commented 4 years ago

In the deleteCover function of ServiceClass, the coverId and graphId parameters are mixed up when calling deleteCover of the EntityHandler. This prevents deletion for most covers. The fix puts the parameters in correct order.

pedela commented 4 years ago

On a side note..any reason you don't merge your repository here as a whole (Rights issues?)?

MaxKissgen commented 4 years ago

No, no rights issues. But as I still might do some fixing and polishing I thought it would be a bit more clean when I do such a "merge" at the end rather than creating more pull requests than might be needed.

Or do you mean why I create pull requests instead of doing branches on the main repo? In that case I guess its rights issues