search

rwth-acis / REST-OCD-Services

This repository contains the OCD service of WebOCD. In the repository, java based codes of overlapping community detection algorithms (OCDA) can be found.
Apache License 2.0
14 stars 10 forks source link

Standardized algorithm output log #68

Open beka-zhvania opened 2 years ago

beka-zhvania commented 2 years ago

The point of this was to standardize console output since it differed among algorithms. But yeah, it makes more sense to use a logger and actually do it directly from the Serviceclass when calling the algorithm. I'll change that

beka-zhvania commented 2 years ago

Issues with logging

  1. Logging number of communities found from within the service class (runAlgorithm method) requires waiting for the algorithm execution to finish, which would result in unnecessary blocking.
  2. using L2pLogger only makes sense from within a service class, so using it from detectOverlappingCommunities method of OCD algorithms is not viable.