search

rwth-acis / RequirementsBazaar

Requirements Bazaar, the continuous innovation platform. Repository of the microservice backend using las2peer, made with love in Aachen, Germany.
https://requirements-bazaar.org
Other
12 stars 2 forks source link

Fix: member cannot develop requirement #167

Closed fxjordan closed 2 years ago

fxjordan commented 2 years ago

Fixes first part of #166 (members could not develop requirement)

codecov[bot] commented 2 years ago

Codecov Report

Merging #167 (170fdc7) into develop (30cfc1d) will decrease coverage by 0.01%. The diff coverage is 34.09%.

@@              Coverage Diff              @@
##             develop     #167      +/-   ##
=============================================
- Coverage      34.70%   34.69%   -0.02%     
  Complexity       466      466              
=============================================
  Files             97       97              
  Lines           6912     6914       +2     
  Branches         672      672              
=============================================
  Hits            2399     2399              
- Misses          4295     4297       +2     
  Partials         218      218
Flag Coverage Δ
unittests 34.69% <34.09%> (-0.02%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../bazaar/service/security/AuthorizationManager.java 86.66% <ø> (ø)
...bazaar/service/resources/RequirementsResource.java 15.80% <21.05%> (-0.04%) :arrow_down:
...cis/bazaar/service/resources/CategoryResource.java 15.44% <28.57%> (ø)
...cis/bazaar/service/resources/CommentsResource.java 15.15% <28.57%> (ø)
...cis/bazaar/service/resources/ProjectsResource.java 28.72% <60.00%> (ø)
...cis/bazaar/service/resources/FeedbackResource.java 58.57% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 30cfc1d...170fdc7. Read the comment docs.

fxjordan commented 2 years ago

"Undeveloping" is also not working (same problem: missing context)

fxjordan commented 2 years ago

We rename the context specific version of isAuthorized(...) method to avoid confusion

The isAuthorized(...) method checks a privilege globally, while the other only checks a privilege for a certain project. Using the same name here leads to using the wrong check by accident, which caused a bug lately.