rwth-acis / mobsos-evaluation-center

Web UI for collaborative success modeling
3 stars 1 forks source link

Internal component input structure needs to be changed #131

Closed lakhoune closed 2 years ago

lakhoune commented 2 years ago

Currently, the visualization components get the measure as input, then extract the query, fetch the data and then make a request to the backend for the data.

When we introduce the LimeSurvey integration, we need to introduce a new LimesurveyMeasure class since it is different to the current implementation (it has no sql query to execute) Since the LimesurveyMeasure doesn't contain a query so we cannot just pass this to the visualization module. If we want to reuse the visualization module for LimeSurvey measures, we need to adjust the input sent to the visualization module.

My proposition is to create 1 new component for the limesurvey measure and adjust the visualization module to take the actual data as input. The transformations from measure to data are done in the SuccessMeasure component and LimeSurveyMeasure component respectively. (The limesurvey measure component needs to transform the data to be in the same format as returned by the query visualization backend

lakhoune commented 2 years ago

we can also remove the visualization component since all of the functionality is overwritten anyways by the different visualization components