search

rwth-acis / moodle-data-proxy

3 stars 1 forks source link

Refactor moodle-data-proxy service #10

Open Leogomat opened 4 years ago

Leogomat commented 4 years ago

Refactor and document the source code of the service

Leogomat commented 4 years ago

Comment made by @Arj-Shahid on the original Jira issue on 12/12/19:

"Code Refactoring:

Refactored the moodle-data-proxy service by splitting down the spaghetti code into multiple functions. Some code clean-up was done which includes renaming of variables, removing unnecessary variables and deleted redundant code.

Added xAPI validation: The recent version of moodle-data-proxy xAPI statements do not contain properties like scale, grade min, grade max, grade raw, success and duration therefore to cater to this problem the service has been modified to include all the necessary functions to include these parameters in xAPI statements. Moodle data proxy service now contains two sub folders : MoodleDataPOJO and xAPIStatements. The former contains classes for Moodle user data and moodle user grade items data - just to make sense of the type of data that is being retrieved from moodle. The latter contains just an xAPIStatements class to convert the json objects to xAPI statements which is to be sent to LRS."