search

rwth-i6 / i6_models

Collection of NN-Model parts
Mozilla Public License 2.0
1 stars 0 forks source link

Sequence masking True/False mapping doc conformer #30

Closed Atticus1806 closed 5 months ago

Atticus1806 commented 1 year ago

https://github.com/rwth-i6/i6_models/blob/d2c8a246ce1174e098de7aa2208e6e7a05eebdb7/i6_models/assemblies/conformer/conformer_v1.py#L55

I just realized, this is wrong or did we agree on something else and I forgot? Since the MHSA module inverts the mask

kuacakuaca commented 5 months ago

fixed by https://github.com/rwth-i6/i6_models/pull/46.