search

rwth-i6 / pytorch-to-returnn

Make PyTorch code runnable within RETURNN
3 stars 6 forks source link

add _FunctionalConvNd._get_output_shape_from_returnn #132

Closed vieting closed 1 year ago

vieting commented 1 year ago

_FunctionalConvNd is missing a _get_output_shape_from_returnn() method. It is very similar to the one of _ConvNd.

vieting commented 1 year ago

The failing tests are the ones from https://github.com/rwth-i6/pytorch-to-returnn/issues/125.

albertz commented 1 year ago

I wonder if this could share some code.

I also wonder whether this is still correct when you operate on other axes, as I mentioned in the other issue.

But anyway, fine for now.