Incorrect type annotations for rqmt in task.py

rwth-i6 / sisyphus

A Workflow Manager in Python

Mozilla Public License 2.0

45 stars 25 forks source link

Incorrect type annotations for rqmt in task.py #197

Closed jtrmal closed 4 months ago

jtrmal commented 4 months ago

Seems to me (and to my editor) it shouldn't be rqmt: dict[str] but rqmt: Optional[typing.Dict[str, Any]] (since typically you have None as a default value ) Can you plz confirm if you care about me submitting a PR or not? Thanks!

JackTemaki commented 4 months ago

Can confirm! I think for docstrings you can simply write dict[str, Any] | None though...

michelwi commented 4 months ago

yes pls, PR welcome.

jtrmal commented 4 months ago

Seems like this has been resolved in the master last week(?), closing. Apologies for the noise.