search

rwthmoodle / moodle-mod_cardbox

The Card Box activity can help your students memorize vocabulary, technical terms, formulas and definitions.
2 stars 2 forks source link

consider breaking up your controller file into classes a bit more #12

Open danmarsden opened 1 year ago

danmarsden commented 1 year ago

one example of how this could be done is the way mod_assign view() class handles actions: https://github.com/moodle/moodle/blob/master/mod/assign/locallib.php#L511-L541

not a blocker for approval - feel free to close as won't fix - it's just that controller file is starting to look a bit messy.

Amrita1991 commented 1 year ago

I actually am aware about it. I intend to fix it but yea nopt immediately..maybe with a new version in the future so I am keeping it open